Discussion:
[PATCH] mtd: rawnand: Add all 1.8V AC chips have a broken GET_FEATURES(TIMINGS)
m***@mxic.com.tw
2018-10-25 06:44:30 UTC
Permalink
From: Mason Yang <***@mxic.com.tw>

Hi Boris,
I patched this for Macronix all 1.8V AC chips.
Thanks for your review.

best regards,
Mason

Mason Yang (1):
mtd: rawnand: Add All 1.8V AC chips have a broken
GET_FEATURES(TIMINGS)

drivers/mtd/nand/raw/nand_macronix.c | 7 +++++++
1 file changed, 7 insertions(+)
--
1.9.1
m***@mxic.com.tw
2018-10-25 06:44:31 UTC
Permalink
From: Mason Yang <***@mxic.com.tw>

Make sure we flag all 1.8V broken chips as not supporting this features.

Signed-off-by: Mason Yang <***@mxic.com.tw>
---
drivers/mtd/nand/raw/nand_macronix.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/mtd/nand/raw/nand_macronix.c b/drivers/mtd/nand/raw/nand_macronix.c
index 49c546c..3836544 100644
--- a/drivers/mtd/nand/raw/nand_macronix.c
+++ b/drivers/mtd/nand/raw/nand_macronix.c
@@ -33,6 +33,13 @@ static void macronix_nand_fix_broken_get_timings(struct nand_chip *chip)
"MX30LF4G18AC",
"MX30LF4G28AC",
"MX60LF8G18AC",
+ "MX30UF1G18AC",
+ "MX30UF1G16AC",
+ "MX30UF2G18AC",
+ "MX30UF2G16AC",
+ "MX30UF4G18AC",
+ "MX30UF4G16AC",
+ "MX30UF4G28AC",
};

if (!chip->parameters.supports_set_get_features)
--
1.9.1
Miquel Raynal
2018-11-11 20:55:31 UTC
Permalink
Hi Mason,
Post by m***@mxic.com.tw
Make sure we flag all 1.8V broken chips as not supporting this features.
---
Applied to nand/next (with the title slightly modified).

Thanks,
Miquèl

Boris Brezillon
2018-10-25 07:16:53 UTC
Permalink
Hi Mason,

On Thu, 25 Oct 2018 14:44:30 +0800
Post by m***@mxic.com.tw
Hi Boris,
I patched this for Macronix all 1.8V AC chips.
Thanks for your review.
No need to add a cover letter when you only have patch.
Post by m***@mxic.com.tw
best regards,
Mason
mtd: rawnand: Add All 1.8V AC chips have a broken
GET_FEATURES(TIMINGS)
drivers/mtd/nand/raw/nand_macronix.c | 7 +++++++
1 file changed, 7 insertions(+)
Boris Brezillon
2018-10-25 07:17:13 UTC
Permalink
On Thu, 25 Oct 2018 09:16:53 +0200
Post by Boris Brezillon
Hi Mason,
On Thu, 25 Oct 2018 14:44:30 +0800
Post by m***@mxic.com.tw
Hi Boris,
I patched this for Macronix all 1.8V AC chips.
Thanks for your review.
No need to add a cover letter when you only have patch.
^ one
Post by Boris Brezillon
Post by m***@mxic.com.tw
best regards,
Mason
mtd: rawnand: Add All 1.8V AC chips have a broken
GET_FEATURES(TIMINGS)
drivers/mtd/nand/raw/nand_macronix.c | 7 +++++++
1 file changed, 7 insertions(+)
Loading...