[PATCH] mtd: nftl: use %*ph to print small buffer

[Antonio Cardace]

Use %*ph format to print small buffer as hex string.

Suggested-by: Andy Shevchenko <***@linux.intel.com>
Signed-off-by: Antonio Cardace <***@gmail.com>
---
What about this one?

drivers/mtd/nftlmount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
index 184c8fbfe465..a8bdc1455b50 100644
--- a/drivers/mtd/nftlmount.c
+++ b/drivers/mtd/nftlmount.c
@@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord *nftl)
if (memcmp(buf, "ANAND", 6)) {
printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but went away on reread!\n",
block * nftl->EraseSize, nftl->mbd.mtd->index);
- printk(KERN_NOTICE "New data are: %02x %02x %02x %02x %02x %02x\n",
- buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
+ printk(KERN_NOTICE "New data are: %6ph\n", buf);
continue;
}
#endif

[Andy Shevchenko]

Post by Antonio Cardace
Use %*ph format to print small buffer as hex string.

Any comments so far?

Post by Antonio Cardace
---
drivers/mtd/nftlmount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
index 184c8fbfe465..a8bdc1455b50 100644
--- a/drivers/mtd/nftlmount.c
+++ b/drivers/mtd/nftlmount.c
@@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord *nftl)
if (memcmp(buf, "ANAND", 6)) {
printk(KERN_NOTICE "ANAND header found at
0x%x in mtd%d, but went away on reread!\n",
block * nftl->EraseSize, nftl-

Post by Antonio Cardace
mbd.mtd->index);

- printk(KERN_NOTICE "New data are: %02x %02x
%02x %02x %02x %02x\n",
- buf[0], buf[1], buf[2], buf[3],
buf[4], buf[5]);
+ printk(KERN_NOTICE "New data are: %6ph\n",
buf);
continue;
}
#endif

[Boris Brezillon]

On Tue, 13 Feb 2018 17:52:45 +0000

Post by Antonio Cardace
Use %*ph format to print small buffer as hex string.

Applied.

Thanks,

Boris

Post by Antonio Cardace
---
What about this one?
drivers/mtd/nftlmount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
index 184c8fbfe465..a8bdc1455b50 100644
--- a/drivers/mtd/nftlmount.c
+++ b/drivers/mtd/nftlmount.c
@@ -122,8 +122,7 @@ static int find_boot_record(struct NFTLrecord *nftl)
if (memcmp(buf, "ANAND", 6)) {
printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but went away on reread!\n",
block * nftl->EraseSize, nftl->mbd.mtd->index);
- printk(KERN_NOTICE "New data are: %02x %02x %02x %02x %02x %02x\n",
- buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
+ printk(KERN_NOTICE "New data are: %6ph\n", buf);
continue;
}
#endif