Discussion:
[PATCH] mtd: nand: drop kernel-doc notation for a deleted function parameter
Randy Dunlap
2018-11-05 02:38:35 UTC
Permalink
From: Randy Dunlap <***@infradead.org>

Remove kernel-doc notation for a deleted function parameter to prevent
a kernel-doc warning:

../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'

Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")

Signed-off-by: Randy Dunlap <***@infradead.org>
Cc: Boris Brezillon <***@bootlin.com>
Cc: Miquel Raynal <***@bootlin.com>
Cc: Richard Weinberger <***@nod.at>
---

drivers/mtd/nand/raw/nand_base.c | 1 -
1 file changed, 1 deletion(-)

--- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
+++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
@@ -590,7 +590,6 @@ retry:

/**
* panic_nand_wait - [GENERIC] wait until the command is done
- * @mtd: MTD device structure
* @chip: NAND chip structure
* @timeo: timeout
*
Miquel Raynal
2018-11-05 08:19:46 UTC
Permalink
Hi Randy,

Subject prefix should be "mtd: rawnand:".
Post by Randy Dunlap
Remove kernel-doc notation for a deleted function parameter to prevent
../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
---
Reviewed-by: Miquel Raynal <***@bootlin.com>


Thanks,
Miquèl
Boris Brezillon
2018-11-05 22:58:30 UTC
Permalink
On Sun, 4 Nov 2018 18:38:35 -0800
Post by Randy Dunlap
Remove kernel-doc notation for a deleted function parameter to prevent
../drivers/mtd/nand/raw/nand_base.c:603: warning: Excess function parameter 'mtd' description in 'panic_nand_wait'
Fixes: f1d46942e823 ("mtd: rawnand: Pass a nand_chip object to chip->waitfunc()")
Queued to the fixes branch.

Thanks,

Boris
Post by Randy Dunlap
---
drivers/mtd/nand/raw/nand_base.c | 1 -
1 file changed, 1 deletion(-)
--- lnx-420-rc1.orig/drivers/mtd/nand/raw/nand_base.c
+++ lnx-420-rc1/drivers/mtd/nand/raw/nand_base.c
/**
* panic_nand_wait - [GENERIC] wait until the command is done
*
Loading...