[BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller

Discussion:

[BUG BISECT] Missing MTD NAND partitions - mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

Boris Brezillon

2018-11-20 12:08:59 UTC

On Tue, 20 Nov 2018 12:48:46 +0100

Hi Krzysztof,

Hi all,
Since few days linux-next has problem on Freescale VF500 - MTD seems
to be broken.
Bisect pointed me to commit 7c27338c728e39ef47c83d101959aa332506969d
("mtd: rawnand: Move the ->exec_op() method to nand_controller_ops")
as reason of failure to find MTD partitions.
Toradex Colibri VF50 on Iris board (ARMv7, UP, Cortext-A5, NXP VF500,
128 MB RAM, 128 MB NAND, Systemd: v232) booted from NFS root (NFSv4)
trying to mount UBIFS from NAND/MTD. Board uses VF610 NAND driver.
The MTD partitions are missing entirely (nothing under /dev/mtd).
[ 1.232161] UBI error: cannot open mtd ubi2, error -2
Attached - dmesg.log
Let me know if you need defconfig or any other information.

Thank you very much for testing and reporting the bug!
Could you please test with this diff applied [1] please? We discussed
with Boris and we think it should fix your setup (and all others also
impacted).
[1] http://code.bulix.org/r1m99i-509201

error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
Maybe you have a git tree with this somewhere?

Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix

Krzysztof Kozlowski

2018-11-20 12:15:04 UTC

Permalink

On Tue, 20 Nov 2018 at 13:09, Boris Brezillon

Post by Boris Brezillon
On Tue, 20 Nov 2018 12:48:46 +0100

Hi Krzysztof,

error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
Maybe you have a git tree with this somewhere?

Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix

Works fine now, thanks!
Tested-by: Krzysztof Kozlowski <***@kernel.org>

Best regards,
Krzysztof

Krzysztof Kozlowski

2018-12-05 16:10:38 UTC

Permalink

Post by Krzysztof Kozlowski
On Tue, 20 Nov 2018 at 13:09, Boris Brezillon

Post by Boris Brezillon
On Tue, 20 Nov 2018 12:48:46 +0100

Hi Krzysztof,

error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
Maybe you have a git tree with this somewhere?

Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix

Works fine now, thanks!

Although the patch fixed the issue... but it seems it is not in
linux-next. The next is broken since almost two weeks.

Best regards,
Krzysztof

Miquel Raynal

2018-12-05 16:14:35 UTC

Permalink

Hi Krzysztof,

Post by Krzysztof Kozlowski

Post by Krzysztof Kozlowski
On Tue, 20 Nov 2018 at 13:09, Boris Brezillon

Post by Boris Brezillon
On Tue, 20 Nov 2018 12:48:46 +0100

Hi Krzysztof,

error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
Maybe you have a git tree with this somewhere?

Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix

Works fine now, thanks!

Although the patch fixed the issue... but it seems it is not in
linux-next. The next is broken since almost two weeks.

Sorry, this is definitely in my TODO list, I need to put the NAND
branch in shape this week anyway.

Thanks,
Miquèl

Miquel Raynal

2018-12-06 20:14:04 UTC

Permalink

Hi Krzysztof,

Post by Krzysztof Kozlowski

Post by Krzysztof Kozlowski
On Tue, 20 Nov 2018 at 13:09, Boris Brezillon

Post by Boris Brezillon
On Tue, 20 Nov 2018 12:48:46 +0100

Hi Krzysztof,

error: patch failed: drivers/mtd/nand/raw/nand_base.c:4399
error: drivers/mtd/nand/raw/nand_base.c: patch does not apply
Maybe you have a git tree with this somewhere?

Yep: https://github.com/bbrezillon/linux/tree/nand/next-fix

Works fine now, thanks!

Although the patch fixed the issue... but it seems it is not in
linux-next. The next is broken since almost two weeks.
Best regards,
Krzysztof

Sorry for the huge delay, fixup applied.

Thanks,
Miquèl